Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archery Categories Expanded #229

Closed
wants to merge 8 commits into from

Conversation

sayscraig
Copy link

Updated to adjust the archery category structure and add some additional archery categories that are necessary.

At Editions.dev I spoke to someone about Shopify working with some merchants in niche industries to help expand the categories and was hoping to make contact with someone there to discuss the archery niche since we are the largest merchant in the industry. Please let me know if that is possible.

@sayscraig
Copy link
Author

I have signed the CLA!

@sayscraig
Copy link
Author

/generate_dist

@ricardotejedorsanz ricardotejedorsanz self-assigned this Jul 9, 2024
data/categories/sg_sporting_goods.yml Outdated Show resolved Hide resolved
data/categories/sg_sporting_goods.yml Outdated Show resolved Hide resolved
@sayscraig
Copy link
Author

/generate_dist

@sayscraig
Copy link
Author

Cleary I am not having my best day finding all the typos ha. Will need to find a better way to debug locally first at some point.

@elsom25
Copy link
Collaborator

elsom25 commented Jul 11, 2024

@sayscraig all good! We're still early days on how we approach all this too 😁 Give us a beat to absorb some of this (and incorporate it into a bundle of internal details we have) (cc @ricardotejedorsanz)

@ricardotejedorsanz
Copy link
Contributor

@sayscraig First, thank you for your incredible contributions. We're currently working on integrating these suggestions to ensure consistency across our taxonomy. Please bear with us as we implement these changes in upcoming updates! In the meantime, do you have any links we could take a look at to support these changes? I'd also be more than happy to schedule a chat if you have a few minutes to spare 😄

@sayscraig
Copy link
Author

@ricardotejedorsanz I would love to chat, that would be fantastic. What is the best way to connect?

Here are a couple links as well.

Filters show archery styles: https://lancasterarchery.com/collections/arrows
Menu on the website will also show the breakdown of categories into the categories I have added like mechanical/fixed blade broadheads, expanded Bow & Crossbow accessories categories, and all the others.

@ricardotejedorsanz
Copy link
Contributor

Hi @sayscraig, thanks again for chatting with me the other day!

Suggesting a few changes following our discussion:

  • New attributes for Archery target types instead of categories
  • ID changes for consistency within our tree
  • Created a Broadhead type attribute instead of categories to avoid going as deep as L8 in the tree (hope this is alright!)

Please let me know if you have any comments, and bear with us while we work on making these changes available in our next taxonomy release.

@ricardotejedorsanz
Copy link
Contributor

fyi @elsom25 @tylerrowsell @KComrade53 placeholder commit with a few tweaks, pending changes to the ./integrations files for the next release. Also pending new attribute descriptions + translations.

@sayscraig
Copy link
Author

@ricardotejedorsanz those updates sounds great to me. I agree with the broadhead type as well, that was a good call.

@sayscraig
Copy link
Author

@ricardotejedorsanz Do I need to do anything on these reviews that failed here? I have signed the CLA! so I am not sure if that fail is due to me or someone else?

Just wanna make sure I'm not holding this up at all on my end.

@elsom25
Copy link
Collaborator

elsom25 commented Aug 6, 2024

@sayscraig at this point I'd say its on us — selfishly I want to use this to test a few "tools" we're adding to the repo as well to see if they help with these kinds of things.

It will certainly be addressed before our next version cutoff (also no idea why the CLA bot is confused all of a sudden 🥲 )

@sayscraig
Copy link
Author

@elsom25 Hi just checking in since I assume we are getting close to the release of these changes. Hoping to confirm that the plan is still for this PR to get merged and released soon?

@ricardotejedorsanz
Copy link
Contributor

Hi @sayscraig, sorry for the wait! We're working through pending PRs this week and are still on track to go live in the next few weeks. Thanks for your patience! 🙏

@ricardotejedorsanz
Copy link
Contributor

Moving to #391 to override merging issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2024-10 taxonomy-tree-requests Suggestion to improve to the taxonomy tree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants